Cleanup the template documentation after RNGP & hermesEnabled to gradle.properties #35108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40762872 |
ecreeth
reviewed
Oct 27, 2022
template/android/gradle.properties
Outdated
| @@ -38,3 +38,7 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64 | |||
| # to write custom TurboModules/Fabric components OR use libraries that | |||
| # are providing them. | |||
| newArchEnabled=false | |||
|
|
|||
| # Use this property to enable or disable the Hermes JS engine. | |||
| # If set to true, you will be using JSC instead. | |||
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Oct 27, 2022
…le.properties (facebook#35108) Summary: Pull Request resolved: facebook#35108 I've rewritten the comment in the android/app/build.gradle. They were really old, contained wrong links and most of the people ignored it. I've also moved the enabling of Hermes to the `gradle.properties` file. RNGP still supports the old method, but we must be sure that we notify library authors if they were reading project.ext.react.enableHermes in the past (also the website needs to be updated). I've also cleaned up the CircleCI setup as now we can specify Hermes enabled/disabled via the CLI (this will also make easier to do e2e testing). Changelog: [Android] [Changed] - Cleanup the template documentation after RNGP & hermesEnabled to gradle.properties Reviewed By: cipolleschi Differential Revision: D40762872 fbshipit-source-id: ccb50740f72bf9be17e1dd241a81bd7da42a7708
cortinico
force-pushed
the
export-D40762872
branch
from
a37d7cd to
2af254c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40762872 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Oct 27, 2022
…le.properties (facebook#35108) Summary: Pull Request resolved: facebook#35108 I've rewritten the comment in the android/app/build.gradle. They were really old, contained wrong links and most of the people ignored it. I've also moved the enabling of Hermes to the `gradle.properties` file. RNGP still supports the old method, but we must be sure that we notify library authors if they were reading project.ext.react.enableHermes in the past (also the website needs to be updated). I've also cleaned up the CircleCI setup as now we can specify Hermes enabled/disabled via the CLI (this will also make easier to do e2e testing). Changelog: [Android] [Changed] - Cleanup the template documentation after RNGP & hermesEnabled to gradle.properties Reviewed By: cipolleschi Differential Revision: D40762872 fbshipit-source-id: 9373a65e7d44840dafe4d7f333cf83b66d146eea
cortinico
force-pushed
the
export-D40762872
branch
from
2af254c to
6a24791
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40762872 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D40762872 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Oct 27, 2022
…le.properties (facebook#35108) Summary: Pull Request resolved: facebook#35108 I've rewritten the comment in the android/app/build.gradle. They were really old, contained wrong links and most of the people ignored it. I've also moved the enabling of Hermes to the `gradle.properties` file. RNGP still supports the old method, but we must be sure that we notify library authors if they were reading project.ext.react.enableHermes in the past (also the website needs to be updated). I've also cleaned up the CircleCI setup as now we can specify Hermes enabled/disabled via the CLI (this will also make easier to do e2e testing). Changelog: [Android] [Changed] - Cleanup the template documentation after RNGP & hermesEnabled to gradle.properties Reviewed By: cipolleschi Differential Revision: D40762872 fbshipit-source-id: 289f04f87b278097337db88a4474beecb2f2717a
cortinico
force-pushed
the
export-D40762872
branch
from
6a24791 to
bae6f3d
Compare
…le.properties (facebook#35108) Summary: Pull Request resolved: facebook#35108 I've rewritten the comment in the android/app/build.gradle. They were really old, contained wrong links and most of the people ignored it. I've also moved the enabling of Hermes to the `gradle.properties` file. RNGP still supports the old method, but we must be sure that we notify library authors if they were reading project.ext.react.enableHermes in the past (also the website needs to be updated). I've also cleaned up the CircleCI setup as now we can specify Hermes enabled/disabled via the CLI (this will also make easier to do e2e testing). Changelog: [Android] [Changed] - Cleanup the template documentation after RNGP & hermesEnabled to gradle.properties Reviewed By: cipolleschi Differential Revision: D40762872 fbshipit-source-id: 58fd2c87b3460da21f2560d7beb93710b626cda5
cortinico
force-pushed
the
export-D40762872
branch
from
bae6f3d to
be72feb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40762872 |
Base commit: ba5454c |
Base commit: ba5454c |
|
PR build artifact for be72feb is ready. |
|
PR build artifact for be72feb is ready. |
|
This pull request was successfully merged by @cortinico in 6a43faf. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…le.properties (facebook#35108) Summary: Pull Request resolved: facebook#35108 I've rewritten the comment in the android/app/build.gradle. They were really old, contained wrong links and most of the people ignored it. I've also moved the enabling of Hermes to the `gradle.properties` file. RNGP still supports the old method, but we must be sure that we notify library authors if they were reading project.ext.react.enableHermes in the past (also the website needs to be updated). I've also cleaned up the CircleCI setup as now we can specify Hermes enabled/disabled via the CLI (this will also make easier to do e2e testing). Changelog: [Android] [Changed] - Cleanup the template documentation after RNGP & hermesEnabled to gradle.properties Reviewed By: cipolleschi Differential Revision: D40762872 fbshipit-source-id: 2c09245e0a923faac53cc6c8a89e99788ae47f8a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I've rewritten the comment in the android/app/build.gradle.
They were really old, contained wrong links and most of the people ignored it.
I've also moved the enabling of Hermes to the
gradle.propertiesfile.RNGP still supports the old method, but we must be sure that we notify
library authors if they were reading project.ext.react.enableHermes in the past
(also the website needs to be updated).
I've also cleaned up the CircleCI setup as now we can specify Hermes enabled/disabled
via the CLI (this will also make easier to do e2e testing).
Changelog:
[Android] [Changed] - Cleanup the template documentation after RNGP & hermesEnabled to gradle.properties
Differential Revision: D40762872